Skip to content

feat: log Required tool with debug severity #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

kittaakos
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Feature.

What is the current behavior?

Logging with info generates too much noise.

What is the new behavior?

Log Required tool with debug severity.

Does this PR introduce a breaking change, and is titled accordingly?

No.

Other information

Closes #2313

Logging with `info` generates too much noise.

Closes arduino#2313

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3f5c0eb) 63.87% compared to head (bcf0103) 63.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2314   +/-   ##
=======================================
  Coverage   63.87%   63.87%           
=======================================
  Files         212      212           
  Lines       19873    19873           
=======================================
  Hits        12693    12693           
  Misses       6089     6089           
  Partials     1091     1091           
Flag Coverage Δ
unit 63.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/cores/packagemanager/package_manager.go 76.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 8c81d2c into arduino:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Required tool with debug severity instead of info
3 participants